Fixed 13.6 -> 14 TeV rounding error (proper) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the previous hotfix (interim PR). Sqrts=13.6 is properly parsed to path, rather than floored first.
usarica
suggested changes
Jul 15, 2023
Contributor
usarica
left a comment
usarica
left a comment
There was a problem hiding this comment.
Thanks, looks ok. I will block the merge until data files are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the previous hotfix (interim PR, #26). Sqrts=13.6 is properly parsed to path, rather than floored first. This PR is intended to be merged when sqrts=13.6 TeV production is ready.